yurinaryshkin commented on code in PR #11118:
URL: https://github.com/apache/ignite/pull/11118#discussion_r1466145667
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/dump/CreateDumpFutureTask.java:
##########
@@ -708,7 +714,12 @@ private boolean writtenByIterator(int cache,
KeyCacheObject key, CacheObjectCont
while (writers.get() > 0) // Waiting for all on the fly listeners
to complete.
LockSupport.parkNanos(1_000_000);
- U.closeQuiet(file);
+ try {
+ file.close();
+ }
+ catch (IOException e) {
+ throw new IgniteException(e);
Review Comment:
Yes, it is tested in
`IgniteCacheDumpSelfTest#testDumpCancelOnFileCreateError`. Also added extra
checks to make sure ignite provides data after the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
