AMashenkov commented on code in PR #3058:
URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1467477590
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/descriptors/CatalogObjectDescriptor.java:
##########
@@ -19,17 +19,22 @@
import static
org.apache.ignite.internal.catalog.CatalogManagerImpl.INITIAL_CAUSALITY_TOKEN;
-import java.io.Serializable;
+import java.io.IOException;
import java.util.Objects;
+import
org.apache.ignite.internal.catalog.descriptors.CatalogObjectDescriptor.CatalogDescriptorBaseSerializer.CatalogDescriptorBase;
+import
org.apache.ignite.internal.catalog.serialization.CatalogObjectSerializer;
import org.apache.ignite.internal.catalog.storage.UpdateEntry;
import org.apache.ignite.internal.tostring.S;
+import org.apache.ignite.internal.util.io.IgniteDataInput;
+import org.apache.ignite.internal.util.io.IgniteDataOutput;
/**
* Base class for catalog objects.
* TODO: IGNITE-19082 Implement custom effective serialization instead.
*/
-public abstract class CatalogObjectDescriptor implements Serializable {
- private static final long serialVersionUID = -6525237234280004860L;
+public abstract class CatalogObjectDescriptor {
+ public static CatalogDescriptorBaseSerializer SERIALIZER = new
CatalogDescriptorBaseSerializer();
Review Comment:
Let's avoid serialization for abstract classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
