AMashenkov commented on code in PR #3058: URL: https://github.com/apache/ignite-3/pull/3058#discussion_r1467482237
########## modules/catalog/src/main/java/org/apache/ignite/internal/catalog/serialization/CatalogSerializationUtils.java: ########## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.catalog.serialization; + +import java.io.DataInput; +import java.io.DataOutput; +import java.io.IOException; +import java.io.Serializable; +import java.lang.reflect.Array; +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import org.apache.ignite.internal.util.ByteUtils; +import org.apache.ignite.internal.util.io.IgniteDataInput; +import org.apache.ignite.internal.util.io.IgniteDataOutput; +import org.jetbrains.annotations.Nullable; + +/** + * Utility methods used for serializing catalog objects. + */ +public class CatalogSerializationUtils { + /** Reads nullable string. */ + public static @Nullable String readNullableString(DataInput in) throws IOException { + if (!in.readBoolean()) { + return null; + } + + return in.readUTF(); + } + + /** Writes nullable string. */ + public static void writeNullableString(@Nullable String str, DataOutput out) throws IOException { + out.writeBoolean(str != null); + + if (str != null) { + out.writeUTF(str); + } + } + + /** Writes collection containing strings. */ + public static void writeStringCollection(Collection<String> list, DataOutput out) throws IOException { + out.writeInt(list.size()); + + for (String item : list) { + out.writeUTF(item); + } + } + + /** Reads list of strings. */ + public static List<String> readStringList(DataInput in) throws IOException { + int size = in.readInt(); + + return readStringCollection(in, size, new ArrayList<>(size)); + } + + /** Reads set of strings. */ + public static Set<String> readStringSet(DataInput in) throws IOException { + int size = in.readInt(); + + return readStringCollection(in, size, new HashSet<>()); Review Comment: ```suggestion return readStringCollection(in, size, IgniteUtils.newHashSet(size)); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
