sashapolo commented on code in PR #3226: URL: https://github.com/apache/ignite-3/pull/3226#discussion_r1494225844
########## modules/affinity/src/main/java/org/apache/ignite/internal/affinity/Assignments.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.affinity; + +import java.io.Serializable; +import java.util.Collections; +import java.util.Set; +import org.apache.ignite.internal.tostring.IgniteToStringInclude; +import org.apache.ignite.internal.tostring.S; +import org.apache.ignite.internal.util.ByteUtils; + +/** + * Class that encapsulates a set of peers and its metadata. + */ +public class Assignments implements Serializable { + /** Empty assignments. */ + public static final Assignments NO_ASSIGNMENTS = new Assignments(Collections.emptySet()); + + /** Set of peers. */ + @IgniteToStringInclude + private final Set<Assignment> peers; + + /** + * Constructor. + * + * @param peers Set of peers. + */ + public Assignments(Set<Assignment> peers) { + this.peers = peers; + } + + /** + * Returns a set of peers, represented by this assignments instance. + */ + public Set<Assignment> peers() { + return peers; + } + + /** + * Serializes the instance into an array of bytes. + */ + public byte[] toBytes() { + return ByteUtils.toBytes(this); + } + + /** + * Serializes assignments into an array of bytes. + * + * @see #toBytes() + */ + public static byte[] toBytes(Set<Assignment> assignments) { Review Comment: It's a matter of taste, but I think this method is redundant. I believe we should only have one way of doing the same thing. ########## modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java: ########## @@ -186,22 +193,22 @@ public static CompletableFuture<Void> updatePendingAssignmentsKeys( LOG.info( "Update metastore pending partitions key [key={}, partition={}, table={}/{}, newVal={}]", partAssignmentsPendingKey.toString(), partNum, tableDescriptor.id(), tableDescriptor.name(), - ByteUtils.fromBytes(partAssignmentsBytes)); + partAssignments); break; case PLANNED_KEY_UPDATED: LOG.info( "Update metastore planned partitions key [key={}, partition={}, table={}/{}, newVal={}]", partAssignmentsPlannedKey, partNum, tableDescriptor.id(), tableDescriptor.name(), - ByteUtils.fromBytes(partAssignmentsBytes) + partAssignments ); break; case PLANNED_KEY_REMOVED_EQUALS_PENDING: LOG.info( "Remove planned key because current pending key has the same value [key={}, partition={}, table={}/{}, val={}]", partAssignmentsPlannedKey.toString(), partNum, tableDescriptor.id(), tableDescriptor.name(), - ByteUtils.fromBytes(partAssignmentsBytes) + Assignments.fromBytes(partAssignmentsBytes) Review Comment: Why not `partAssignments`? ########## modules/affinity/src/main/java/org/apache/ignite/internal/affinity/Assignments.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.affinity; + +import java.io.Serializable; +import java.util.Collections; +import java.util.Set; +import org.apache.ignite.internal.tostring.IgniteToStringInclude; +import org.apache.ignite.internal.tostring.S; +import org.apache.ignite.internal.util.ByteUtils; + +/** + * Class that encapsulates a set of peers and its metadata. + */ +public class Assignments implements Serializable { + /** Empty assignments. */ + public static final Assignments NO_ASSIGNMENTS = new Assignments(Collections.emptySet()); + + /** Set of peers. */ + @IgniteToStringInclude + private final Set<Assignment> peers; Review Comment: Why is this field called `peers`? Sounds strange to me ########## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java: ########## @@ -1183,15 +1186,15 @@ private CompletableFuture<?> createTableLocally( dataNodes, zoneDescriptor.partitions(), zoneDescriptor.replicas() - )); + ).stream().map(assignments -> new Assignments(assignments)).collect(Collectors.toList())); Review Comment: ```suggestion ).stream().map(Assignments::new).collect(Collectors.toList())); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
