ibessonov commented on code in PR #3226:
URL: https://github.com/apache/ignite-3/pull/3226#discussion_r1494237077
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceUtil.java:
##########
@@ -186,22 +193,22 @@ public static CompletableFuture<Void>
updatePendingAssignmentsKeys(
LOG.info(
"Update metastore pending partitions key [key={},
partition={}, table={}/{}, newVal={}]",
partAssignmentsPendingKey.toString(), partNum,
tableDescriptor.id(), tableDescriptor.name(),
- ByteUtils.fromBytes(partAssignmentsBytes));
+ partAssignments);
break;
case PLANNED_KEY_UPDATED:
LOG.info(
"Update metastore planned partitions key [key={},
partition={}, table={}/{}, newVal={}]",
partAssignmentsPlannedKey, partNum,
tableDescriptor.id(), tableDescriptor.name(),
- ByteUtils.fromBytes(partAssignmentsBytes)
+ partAssignments
);
break;
case PLANNED_KEY_REMOVED_EQUALS_PENDING:
LOG.info(
"Remove planned key because current pending key
has the same value [key={}, partition={}, table={}/{}, val={}]",
partAssignmentsPlannedKey.toString(), partNum,
tableDescriptor.id(), tableDescriptor.name(),
- ByteUtils.fromBytes(partAssignmentsBytes)
+ Assignments.fromBytes(partAssignmentsBytes)
Review Comment:
We already have a class called `Assignment`. I don't want to introduce new
naming, that's confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
