xtern commented on code in PR #3229:
URL: https://github.com/apache/ignite-3/pull/3229#discussion_r1497597451
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/IgniteSqlFunctions.java:
##########
@@ -564,6 +556,14 @@ public static Object consumeFirstArgument(Object args0,
Object args1) {
return args1;
}
+ /** Returns the timestamp value minus the offset of the specified
timezone. */
+ public static Long localTimestampToUtc(Long timestamp, TimeZone timeZone) {
Review Comment:
The idea behind this naming (`localTimestampToUtc`) was that here we have a
point in time represented in the user's local time zone and we converting it
back to `utc` using provided timezone.
Anyway, so far renamed to `subtractTimeZoneOffset` :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
