xtern commented on code in PR #3229:
URL: https://github.com/apache/ignite-3/pull/3229#discussion_r1499102382
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -197,45 +200,127 @@ public void testDateTime() {
assertQuery("SELECT date
'1992-01-19'").returns(sqlDate("1992-01-19")).check();
assertQuery("SELECT date '1992-01-18' + interval (1)
days").returns(sqlDate("1992-01-19")).check();
assertQuery("SELECT date '1992-01-18' + interval (24)
hours").returns(sqlDate("1992-01-19")).check();
+ assertQuery("SELECT timestamp '1992-01-18 02:30:00'")
+ .returns(sqlDateTime("1992-01-18T02:30:00")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-01-18
02:30:00'")
+ .returns(sqlTimestamp("1992-01-18T02:30:00")).check();
assertQuery("SELECT timestamp '1992-01-18 02:30:00' + interval (25)
hours")
.returns(sqlDateTime("1992-01-19T03:30:00")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-01-18
02:30:00' + interval (25) hours")
+ .returns(sqlTimestamp("1992-01-19T03:30:00")).check();
assertQuery("SELECT timestamp '1992-01-18 02:30:00' + interval (23)
hours")
.returns(sqlDateTime("1992-01-19T01:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-01-18
02:30:00' + interval (23) hours")
+ .returns(sqlTimestamp("1992-01-19T01:30:00.000")).check();
assertQuery("SELECT timestamp '1992-01-18 02:30:00' + interval (24)
hours")
.returns(sqlDateTime("1992-01-19T02:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-01-18
02:30:00' + interval (24) hours")
+ .returns(sqlTimestamp("1992-01-19T02:30:00.000")).check();
assertQuery("SELECT date
'1992-03-29'").returns(sqlDate("1992-03-29")).check();
assertQuery("SELECT date '1992-03-28' + interval (1)
days").returns(sqlDate("1992-03-29")).check();
assertQuery("SELECT date '1992-03-28' + interval (24)
hours").returns(sqlDate("1992-03-29")).check();
assertQuery("SELECT timestamp '1992-03-28 02:30:00' + interval (25)
hours")
.returns(sqlDateTime("1992-03-29T03:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-03-28
02:30:00' + interval (25) hours")
+ .returns(sqlTimestamp("1992-03-29T03:30:00.000")).check();
assertQuery("SELECT timestamp '1992-03-28 02:30:00' + interval (23)
hours")
.returns(sqlDateTime("1992-03-29T01:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-03-28
02:30:00' + interval (23) hours")
+ .returns(sqlTimestamp("1992-03-29T01:30:00.000")).check();
assertQuery("SELECT timestamp '1992-03-28 02:30:00' + interval (24)
hours")
.returns(sqlDateTime("1992-03-29T02:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-03-28
02:30:00' + interval (24) hours")
+ .returns(sqlTimestamp("1992-03-29T02:30:00.000")).check();
assertQuery("SELECT date
'1992-09-27'").returns(sqlDate("1992-09-27")).check();
assertQuery("SELECT date '1992-09-26' + interval (1)
days").returns(sqlDate("1992-09-27")).check();
assertQuery("SELECT date '1992-09-26' + interval (24)
hours").returns(sqlDate("1992-09-27")).check();
assertQuery("SELECT timestamp '1992-09-26 02:30:00' + interval (25)
hours")
.returns(sqlDateTime("1992-09-27T03:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-09-26
02:30:00'")
+ .returns(sqlTimestamp("1992-09-26T02:30:00.000")).check();
assertQuery("SELECT timestamp '1992-09-26 02:30:00' + interval (23)
hours")
.returns(sqlDateTime("1992-09-27T01:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-09-26
02:30:00' + interval (23) hours")
+ .returns(sqlTimestamp("1992-09-27T01:30:00.000")).check();
assertQuery("SELECT timestamp '1992-09-26 02:30:00' + interval (24)
hours")
.returns(sqlDateTime("1992-09-27T02:30:00.000")).check();
+ assertQuery("SELECT timestamp with local time zone '1992-09-26
02:30:00' + interval (24) hours")
Review Comment:
Interval tests refactored a bit (basic cases like `select TEMPORAL_TYPE
literal +/- interval N unit` moved to single test
`ItInterval#testBasicDateTimeIntervalArithmetic`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
