xtern commented on code in PR #3336:
URL: https://github.com/apache/ignite-3/pull/3336#discussion_r1512535803
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/CommonsTest.java:
##########
@@ -86,4 +94,10 @@ private static void assertProjectionMapping(ImmutableIntList
source, ImmutableIn
assertEquals(expected, Mappings.apply(mapping, source));
}
+
+ private static class IgniteN {}
+
+ private static class Ignite {}
+
+ private static class Ignit {}
Review Comment:
Done, thanks
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/CommonsTest.java:
##########
@@ -74,6 +74,14 @@ public void testArrayToMap() {
assertEquals(vals, Commons.arrayToMap(new Object[]{1, null, "3"}));
}
+ @Test
+ public void testMakeRelTypeName() {
+ assertEquals("N", Commons.makeRelTypeName(IgniteN.class));
+ assertEquals("Ignite", Commons.makeRelTypeName(Ignite.class));
+ assertEquals("Ignit", Commons.makeRelTypeName(Ignit.class));
Review Comment:
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
