korlov42 commented on code in PR #3336:
URL: https://github.com/apache/ignite-3/pull/3336#discussion_r1512799809


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/AbstractIgniteJoin.java:
##########
@@ -292,4 +292,8 @@ protected Mappings.TargetMapping 
buildTransposeMapping(boolean left2Right) {
                 (left2Right ? right : left).getRowType().getFieldCount()
         );
     }
+
+    @Override public String getRelTypeName() {

Review Comment:
   Does it make sense to introduce abstract class `IgniteSingleRel` with 
overriden `getRelTypeName()` method? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to