AMashenkov commented on code in PR #3350:
URL: https://github.com/apache/ignite-3/pull/3350#discussion_r1514291988
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExchangeServiceImpl.java:
##########
@@ -162,6 +172,10 @@ private void onMessage(String nodeName,
QueryBatchRequestMessage msg) {
}
private void onMessage(String nodeName, QueryBatchMessage msg) {
+ if (!nodeName.equals(localNodeName)) {
+ clock.update(msg.timestamp());
+ }
Review Comment:
I think this should be done at lower-level, e.g. somewhere in Messaging
sub-system.
Shortly, a HLC (or similar) should register a hook in MessageService for
that purpose, instead of shifting a responsibility to the other components.
Let's add a TODO, and create a ticket to fix this, and link current ticket
to a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
