xtern commented on code in PR #3350:
URL: https://github.com/apache/ignite-3/pull/3350#discussion_r1515837506
##########
modules/arch-test/src/test/java/org/apache/ignite/internal/SqlEngineModuleArchTest.java:
##########
@@ -48,10 +48,10 @@ public class SqlEngineModuleArchTest {
.should(new ArchCondition<>("override
org.apache.calcite.rel.RelNode.getRelTypeName") {
@Override
public void check(JavaClass javaClass, ConditionEvents
conditionEvents) {
- boolean overrided = javaClass.getMethods().stream()
- .anyMatch(it ->
"getRelTypeName".equals(it.getName()));
+ boolean methodNotImplemented =
javaClass.getMethods().stream()
+ .noneMatch(it ->
"getRelTypeName".equals(it.getName()));
- if (!overrided) {
+ if (methodNotImplemented) {
Review Comment:
Thanks, changes reverted.
##########
modules/arch-test/src/test/java/org/apache/ignite/internal/SqlEngineModuleArchTest.java:
##########
@@ -48,10 +48,10 @@ public class SqlEngineModuleArchTest {
.should(new ArchCondition<>("override
org.apache.calcite.rel.RelNode.getRelTypeName") {
@Override
public void check(JavaClass javaClass, ConditionEvents
conditionEvents) {
- boolean overrided = javaClass.getMethods().stream()
- .anyMatch(it ->
"getRelTypeName".equals(it.getName()));
+ boolean methodNotImplemented =
javaClass.getMethods().stream()
+ .noneMatch(it ->
"getRelTypeName".equals(it.getName()));
- if (!overrided) {
+ if (methodNotImplemented) {
Review Comment:
Thanks, these changes reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
