korlov42 commented on code in PR #3318:
URL: https://github.com/apache/ignite-3/pull/3318#discussion_r1514613603
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReader.java:
##########
@@ -84,6 +86,21 @@ public static <T extends RelNode> T
fromJson(BaseQueryContext ctx, String json)
return (T) reader.read(json);
}
+ /** Creates a {@link RexNode} from the given json. */
+ public static RexNode fromExprJson(byte[] json) {
Review Comment:
why `byte[]` ?
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPrunerImpl.java:
##########
@@ -71,6 +71,13 @@ public List<MappedFragment> apply(
continue;
}
+ // Do not update colocation groups, in case of correlated fragment,
+ // because partitions for such fragments can be removed only at
runtime.
+ if (fragment.correlated()) {
Review Comment:
this flag will be `false` in case of colocated join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
