lowka commented on code in PR #3318:
URL: https://github.com/apache/ignite-3/pull/3318#discussion_r1515487121
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/externalize/RelJsonReader.java:
##########
@@ -84,6 +86,21 @@ public static <T extends RelNode> T
fromJson(BaseQueryContext ctx, String json)
return (T) reader.read(json);
}
+ /** Creates a {@link RexNode} from the given json. */
+ public static RexNode fromExprJson(byte[] json) {
Review Comment:
`fromExprJson` uses bytes because `toJsonExpr` converts expressions to
bytes[].
And `toJsonExpr` returns an array of bytes, because serialised expressions
are then immediately written to output stream.
An alternative approach would be to convert expression into a string and
then use methods from data stream than convert string into bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
