rpuch commented on code in PR #3385:
URL: https://github.com/apache/ignite-3/pull/3385#discussion_r1522684818
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -231,6 +229,10 @@ public void onWrite(Iterator<CommandClosure<WriteCommand>>
iterator) {
storage.releasePartitionSnapshotsReadLock();
}
+ // Completing the closure out of the partition snapshots lock to
reduce possibility of deadlocks as it might
Review Comment:
I was able to get into a deadlock with a buggy implementation of
`TestPartitionDataStorage` (it was taking an exclusive lock instead of a shared
one). But even with this bug fixed, it seems that everything that can be done
out of a lock should be done out of it. Especially if it can trigger some code
that's hard to imagine right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
