rpuch commented on code in PR #3385:
URL: https://github.com/apache/ignite-3/pull/3385#discussion_r1522686237
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -2665,37 +2686,11 @@ private CompletableFuture<CompletableFuture<?>>
applyUpdateAllCommand(
if (!cmd.full()) {
if (skipDelayedAck) {
- // TODO:
https://issues.apache.org/jira/browse/IGNITE-20124 Temporary code below
- synchronized (safeTime) {
- storageUpdateHandler.handleUpdateAll(
- cmd.txId(),
- cmd.rowsToUpdate(),
- cmd.tablePartitionId().asTablePartitionId(),
- true,
- null,
- null,
- indexIdsAtRwTxBeginTs(transactionId)
- );
-
- updateTrackerIgnoringTrackerClosedException(safeTime,
cmd.safeTime());
- }
+
handleUpdateAllUnderLocksOnSnapshotsAndSafeTime(transactionId, cmd);
Review Comment:
They decrease duplication, hence they decrease a change for an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
