rpuch commented on code in PR #3415:
URL: https://github.com/apache/ignite-3/pull/3415#discussion_r1525833412
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java:
##########
@@ -364,7 +364,10 @@ private GcQueue createGcQueue(
CompletableFuture<Void>
destroyMvPartitionStorage(AbstractPageMemoryMvPartitionStorage
mvPartitionStorage) {
// It is enough for us to close the partition storage and its indexes
(do not destroy). Prepare the data region, checkpointer, and
// compactor to remove the partition, and then simply delete the
partition file and its delta files.
- mvPartitionStorage.close();
+ boolean transitioned = mvPartitionStorage.transitionToDestroyedState();
Review Comment:
It is introduced just to make the code more readable, it explains what it
means. If I inline it, the code would look like `if
mvPartitionStorage.transitionToDestroyedState()`, and it's not obvious right
away what would `true` or `false` mean in this case. But if there is a variable
called `transitioned`, then it's obvious that the transition we tried was
successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
