tkalkirill commented on code in PR #3415:
URL: https://github.com/apache/ignite-3/pull/3415#discussion_r1525836512
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/PersistentPageMemoryTableStorage.java:
##########
@@ -364,7 +364,10 @@ private GcQueue createGcQueue(
CompletableFuture<Void>
destroyMvPartitionStorage(AbstractPageMemoryMvPartitionStorage
mvPartitionStorage) {
// It is enough for us to close the partition storage and its indexes
(do not destroy). Prepare the data region, checkpointer, and
// compactor to remove the partition, and then simply delete the
partition file and its delta files.
- mvPartitionStorage.close();
+ boolean transitioned = mvPartitionStorage.transitionToDestroyedState();
Review Comment:
For me, the variable does not add more clarity, at your discretion, of
course, I would remove it, since the code is not complicated and understandable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
