ibessonov commented on code in PR #3470:
URL: https://github.com/apache/ignite-3/pull/3470#discussion_r1537421681
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/configuration/SchemaSynchronizationConfigurationSchema.java:
##########
@@ -32,7 +33,16 @@
public class SchemaSynchronizationConfigurationSchema {
/** Delay Duration (ms), see the spec for details. */
@Value(hasDefault = true)
- @Range(min = 0)
- // TODO: IGNITE-19792 - make @Immutable when it gets being handled
property for distributed config.
+ @Range(min = 1)
+ @Immutable
public long delayDuration = TimeUnit.SECONDS.toMillis(1);
+
+ /**
+ * Max physical clock skew (ms) that is tolerated by the cluster. If
difference between physical clocks of 2 nodes of a cluster
+ * exceeds this value, the cluster might demonstrate abnormal behavior.
+ */
+ @Value(hasDefault = true)
+ @Range(min = 1)
+ @Immutable
+ public long maxClockSkew = 500;
Review Comment:
Any specific source for this default value? Does this affect our tests
somehow?
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/configuration/SchemaSynchronizationConfigurationSchema.java:
##########
@@ -32,7 +33,16 @@
public class SchemaSynchronizationConfigurationSchema {
/** Delay Duration (ms), see the spec for details. */
@Value(hasDefault = true)
- @Range(min = 0)
- // TODO: IGNITE-19792 - make @Immutable when it gets being handled
property for distributed config.
+ @Range(min = 1)
+ @Immutable
public long delayDuration = TimeUnit.SECONDS.toMillis(1);
+
+ /**
+ * Max physical clock skew (ms) that is tolerated by the cluster. If
difference between physical clocks of 2 nodes of a cluster
+ * exceeds this value, the cluster might demonstrate abnormal behavior.
+ */
+ @Value(hasDefault = true)
+ @Range(min = 1)
+ @Immutable
+ public long maxClockSkew = 500;
Review Comment:
Any specific source for this default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
