rpuch commented on code in PR #3470:
URL: https://github.com/apache/ignite-3/pull/3470#discussion_r1538684506
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -569,6 +573,12 @@ public class IgniteImpl implements Ignite {
metaStorageMgr.configure(clusterConfigRegistry.getConfiguration(MetaStorageConfiguration.KEY));
+ SchemaSynchronizationConfiguration schemaSyncConfig =
clusterConfigRegistry.getConfiguration(
+ SchemaSynchronizationConfiguration.KEY
+ );
+
+ clockService = new ClockServiceImpl(clock, clockWaiter, new
SameValueLongSupplier(() -> schemaSyncConfig.maxClockSkew().value()));
Review Comment:
Even if it's safe to make it mutable, it will take some time to prove this.
I think this needs to be done as a next step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
