tkalkirill commented on code in PR #3484:
URL: https://github.com/apache/ignite-3/pull/3484#discussion_r1538679245
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/RocksDbClusterStateStorage.java:
##########
@@ -86,6 +87,13 @@ public RocksDbClusterStateStorage(Path dbPath, String
nodeName) {
@Override
public CompletableFuture<Void> start() {
+ // delete existing data, relying on log playback
+ try {
+ RocksDB.destroyDB(dbPath.toString(), options);
Review Comment:
We discussed it personally with Ivan, and it became clearer.
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/runner/app/ItIgniteNodeRestartTest.java:
##########
@@ -963,6 +963,27 @@ public void metastorageRecoveryTest(boolean useSnapshot)
throws InterruptedExcep
}
}
+ /**
+ * Checks that logical topology version is maintained after nodes restart.
+ */
+ @Test
+ public void logicalTopologyVersionMaintainedTest() {
+ IgniteImpl main = startNodes(3).get(0);
+
+ stopNode(1);
+ IgniteImpl restarted = startNode(1);
+
+ stopNode(2);
+ IgniteImpl secondRestarted = startNode(2);
+
+ long mainVersion =
main.logicalTopologyService().localLogicalTopology().version();
+ long restartedVersion =
restarted.logicalTopologyService().localLogicalTopology().version();
+ long secondRestartedVersion =
secondRestarted.logicalTopologyService().localLogicalTopology().version();
+
+ assertEquals(mainVersion, restartedVersion);
+ assertEquals(mainVersion, secondRestartedVersion);
Review Comment:
We discussed it personally with Vanya, and it became clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
