tkalkirill commented on code in PR #3484:
URL: https://github.com/apache/ignite-3/pull/3484#discussion_r1538963772


##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/raft/RocksDbClusterStateStorage.java:
##########
@@ -86,12 +87,17 @@ public RocksDbClusterStateStorage(Path dbPath, String 
nodeName) {
 
     @Override
     public CompletableFuture<Void> start() {
-        init();
+        // Delete existing data, relying on log playback.
+        try {
+            RocksDB.destroyDB(dbPath.toString(), options);
+        } catch (RocksDBException e) {
+            return failedFuture(new CmgStorageException("Unable to drop 
RocksDb storage", e));
+        }
 
-        return nullCompletedFuture();
+        return init();

Review Comment:
   Please be careful, this method is used in two places and in the second an 
exception must be thrown.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to