lowka commented on code in PR #3466:
URL: https://github.com/apache/ignite-3/pull/3466#discussion_r1539357891


##########
modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/MarshallerColumn.java:
##########
@@ -68,12 +70,32 @@ public MarshallerColumn(String name, BinaryMode type) {
      * @param defValSup Default value supplier.
      */
     public MarshallerColumn(String name, BinaryMode type, @Nullable 
Supplier<Object> defValSup, int scale) {

Review Comment:
   Remove this CTOR, marked another constructor (which does not provide all the 
fields) as TestOnly.



##########
modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/MarshallerColumn.java:
##########
@@ -68,12 +70,32 @@ public MarshallerColumn(String name, BinaryMode type) {
      * @param defValSup Default value supplier.
      */
     public MarshallerColumn(String name, BinaryMode type, @Nullable 
Supplier<Object> defValSup, int scale) {

Review Comment:
   Removed this CTOR, marked another constructor (which does not provide all 
the fields) as TestOnly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to