korlov42 commented on code in PR #3466:
URL: https://github.com/apache/ignite-3/pull/3466#discussion_r1539521505
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/marshaller/reflection/KvMarshallerImpl.java:
##########
@@ -118,7 +129,7 @@ public K unmarshalKey(Row row) throws MarshallerException {
@Nullable
@Override
public V unmarshalValue(Row row) throws MarshallerException {
- Object o = valMarsh.readObject(new RowReader(row,
schema.keyColumns().size()), null);
+ Object o = valMarsh.readObject(new RowReader(row, valPositions), null);
Review Comment:
i'm wondering why have not we done the same for `unmarshalKey`? I bet it
lack of tests on putAll
##########
modules/marshaller-common/src/main/java/org/apache/ignite/internal/marshaller/MarshallerColumn.java:
##########
@@ -68,12 +70,32 @@ public MarshallerColumn(String name, BinaryMode type) {
* @param defValSup Default value supplier.
*/
public MarshallerColumn(String name, BinaryMode type, @Nullable
Supplier<Object> defValSup, int scale) {
+ this.schemaIndex = -1;
+ this.name = name;
+ this.type = type;
+ this.defValSup = defValSup == null ? NULL_SUPPLIER : defValSup;
+ this.scale = scale;
+ }
+
+ /**
+ * Constructor.
+ *
+ * @param name Column name.
+ * @param type An instance of column data type.
+ * @param defValSup Default value supplier.
Review Comment:
nitpicking: and what about `scale`? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
