xtern commented on code in PR #3474:
URL: https://github.com/apache/ignite-3/pull/3474#discussion_r1541339319
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/UnionPlannerTest.java:
##########
@@ -93,4 +167,14 @@ private static UnaryOperator<TableBuilder>
createTestTable(String tableName) {
.addColumn("NAME", NativeTypes.STRING)
.addColumn("SALARY", NativeTypes.DOUBLE);
}
+
+ private Predicate<? extends RelNode> projectFromTable(String tableName,
String... exprs) {
Review Comment:
It might be worth moving this method to `AbstractPlannerTest` and removing
the duplicate from `SetOpPlannerTest`.
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItSetOpTest.java:
##########
@@ -278,6 +278,25 @@ public void testSetOpDifferentNumericTypes(String setOp,
int expectId, String ex
.check();
}
+ @Test
+ public void testUnionDifferentNumericTypes() {
+ String query = "SELECT * FROM ("
+ + "SELECT id, val FROM t1 "
+ + "UNION "
+ + "SELECT id, val FROM t2) ORDER BY id";
+
+ assertQuery(query)
Review Comment:
JFYI, `assertQuery()..check()` by default tries to sort the "comparable"
results until `ordered()` is set explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
