lowka commented on code in PR #3474:
URL: https://github.com/apache/ignite-3/pull/3474#discussion_r1544269955
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/UnionConverterRule.java:
##########
@@ -48,16 +48,18 @@ public UnionConverterRule(Config cfg) {
/** {@inheritDoc} */
@Override
public void onMatch(RelOptRuleCall call) {
- final LogicalUnion union = call.rel(0);
+ LogicalUnion union = call.rel(0);
RelOptCluster cluster = union.getCluster();
RelTraitSet traits = cluster.traitSetOf(IgniteConvention.INSTANCE);
+
List<RelNode> inputs = Commons.transform(union.getInputs(), input ->
convert(input, traits));
+ List<RelNode> convertedInputs =
Commons.castInputsToLeastRestrictiveTypeIfNeeded(inputs, cluster, traits);
Review Comment:
Yes. Conversion from not nullable to nullable is always safe.
This PR should not touch partition pruning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
