korlov42 commented on code in PR #3513: URL: https://github.com/apache/ignite-3/pull/3513#discussion_r1547227647
########## modules/sql-engine/src/integrationTest/sql/types/date/date_parsing.test_ignore: ########## @@ -1,84 +1,35 @@ # name: test/sql/types/date/date_parsing.test # description: Test date parsing # group: [date] +# Ignore https://issues.apache.org/jira/browse/IGNITE-14602 # Ignore https://issues.apache.org/jira/browse/IGNITE-15619 statement ok PRAGMA enable_verification query I -SELECT '1992-01-01'::DATE::VARCHAR == '1992-01-01' +SELECT '30000-01-01'::DATE::VARCHAR = '30000-01-01' ---- 1 query I -SELECT '1992-09-20'::DATE::VARCHAR == '1992-09-20' Review Comment: it's better not to remove test cases from '_ignored' tests. The idea is to have single file with all the test cases. If you want to see only cases which failed, you can use any diff tool ########## modules/sql-engine/src/integrationTest/sql/types/time/test_time.test: ########## @@ -1,32 +1,35 @@ # name: test/sql/types/time/test_time.test # description: Test basic TIME functionality # group: [time] -# Ignore https://issues.apache.org/jira/browse/IGNITE-15619 statement ok PRAGMA enable_verification statement ok -CREATE TABLE times(i TIME) +CREATE TABLE times(i TIME(3)) statement ok -INSERT INTO times VALUES ('00:01:20'), ('20:08:10.998'), ('20:08:10.33'), ('20:08:10.001'), (NULL) +INSERT INTO times VALUES ('00:01:20'), ('20:08:10.998'), ('20:08:10.33'), ('20:08:10.001') + +# TODO https://issues.apache.org/jira/browse/IGNITE-15123 Multi-tuple insert fails on validation +statement ok +INSERT INTO times VALUES (NULL) query T -SELECT * FROM times +SELECT * FROM times order by i Review Comment: instead of adding `ORDER BY` clause, it's better to use `rowsort` option to do comparison. Please refer to javadoc of `ItSqlLogicTest` for details -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
