xtern commented on code in PR #3513: URL: https://github.com/apache/ignite-3/pull/3513#discussion_r1549272222
########## modules/sql-engine/src/integrationTest/sql/types/time/time_parsing.test: ########## @@ -0,0 +1,40 @@ +# name: test/sql/types/time/time_parsing.test +# description: Test time parsing +# group: [time] +# note: according to SQL standard default TIME precision is 0 (Sql 2011 Part 2 Section 6.1 syntax rule 34) + +statement ok +PRAGMA enable_verification + +query I +SELECT '14:42:04'::TIME::VARCHAR +---- +14:42:04 + +# milliseconds +query I +SELECT '14:42:04.35'::TIME(2)::VARCHAR +---- +14:42:04.35 + +query I +SELECT '14:42:04.999'::TIME(3)::VARCHAR +---- +14:42:04.999 + +query I +SELECT '14:42:04.999'::TIME(6)::VARCHAR +---- +14:42:04.999000 + +# microseconds are not supported yet, result is rounded-up +query I +SELECT '14:42:04.9995'::TIME(6) +---- +14:42:05 + +# zeros are not trimmed +query I +SELECT '14:42:04.9995'::TIME(6)::VARCHAR Review Comment: Yes, I missed those tests, fixed, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
