korlov42 commented on code in PR #3559:
URL: https://github.com/apache/ignite-3/pull/3559#discussion_r1555373927
##########
modules/sql-engine/src/integrationTest/sql/subquery/table/union_all_projection_pushdown.test:
##########
Review Comment:
all test names in the directory starts with `test_` prefix, let's follow
this pattern. Besides, there is already `test_subquery_union.test`, so let's
rename old script and new script to `test_union_of_subquery.test` and
`test_union_in_subquery.test` accordingly to better reflect tests' purposes.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RehashingPartitionExtractor.java:
##########
@@ -39,6 +39,8 @@ public RehashingPartitionExtractor(
/** {@inheritDoc} */
@Override
public int partition(RowT row) {
+ assert fields.length != 0 : "Unexpected partition calculation call";
Review Comment:
does it make sense to check this during object creation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
