zstan commented on code in PR #3559:
URL: https://github.com/apache/ignite-3/pull/3559#discussion_r1557431036
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/RehashingPartitionExtractor.java:
##########
@@ -39,6 +39,8 @@ public RehashingPartitionExtractor(
/** {@inheritDoc} */
@Override
public int partition(RowT row) {
+ assert fields.length != 0 : "Unexpected partition calculation call";
Review Comment:
as i can see for now it possible to call constructor with empty fields, i
append this assertion for signalling that this method never called with empty
fields.
Seems we obtain this situation here :
` Int2ObjectMap<NodeWithConsistencyToken> assignments(List<String>
nodeNames) {
if (!(this instanceof PartitionedTarget)) {
return Int2ObjectMaps.emptyMap();
}`
when this instance of OneOfTarget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
