JAkutenshi opened a new pull request, #3575: URL: https://github.com/apache/ignite-3/pull/3575
The problem was in returning null in cases of `TableManger#writeTableAssignmentsToMetastore` interruption while internal future proceeds. It leads to not caught issues after the method callings. The solution is to throw a specific exception to detect and easily fix any problem during attempt to write assignments into a metastore. In the result: - `WritingAssignmentsToMetastoreException` class is implemented. - In `.exceptionally(...)` case of `TableManger#writeTableAssignmentsToMetastore` now the new exception is thrown. - `TableManagerTest#testWriteTableAssignmentsToMetastoreExceptionally` is introduced with 2 main cases of the method interruption: after and before metastore's invocation completion. There is an issue that in `.exceptionally(...)` for main assignments future we can't got access to completed list, then exception class has additional `isAssignmentsWereAvailable()` method to check if the list wasn't available in a scope while exception throwing. And in `org/apache/ignite/internal/table/distributed/TableManager.java:755` made a check for the nested exception duplicity evasion. --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
