sanpwc commented on code in PR #3575:
URL: https://github.com/apache/ignite-3/pull/3575#discussion_r1570567340
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1240,32 +1264,16 @@ private CompletableFuture<?> createTableLocally(
) {
return inBusyLockAsync(busyLock, () -> {
int tableId = tableDescriptor.id();
- int zoneId = tableDescriptor.zoneId();
// Retrieve descriptor during synchronous call, before the
previous catalog version could be concurrently compacted.
CatalogZoneDescriptor zoneDescriptor =
getZoneDescriptor(tableDescriptor, catalogVersion);
- CompletableFuture<List<Assignments>> assignmentsFuture;
-
- // Check if the table already has assignments in the meta storage
locally.
- // So, it means, that it is a recovery process and we should use
the meta storage local assignments instead of calculation
- // of the new ones.
- if (partitionAssignmentsGetLocally(metaStorageMgr, tableId, 0,
causalityToken) != null) {
- assignmentsFuture = completedFuture(
- tableAssignmentsGetLocally(metaStorageMgr, tableId,
zoneDescriptor.partitions(), causalityToken));
- } else {
- assignmentsFuture =
distributionZoneManager.dataNodes(causalityToken, catalogVersion, zoneId)
- .thenApply(dataNodes ->
AffinityUtils.calculateAssignments(
- dataNodes,
- zoneDescriptor.partitions(),
- zoneDescriptor.replicas()
- ).stream().map(Assignments::of).collect(toList()));
-
- assignmentsFuture.thenAccept(assignmentsList -> {
- LOG.info(IgniteStringFormatter.format("Assignments
calculated from data nodes [table={}, tableId={}, assignments={}, "
- + "revision={}]", tableDescriptor.name(), tableId,
assignmentListToString(assignmentsList), causalityToken));
- });
- }
+ CompletableFuture<List<Assignments>> assignmentsFuture =
createOrGetAssignments(
Review Comment:
getOrCreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
