oleg-vlsk commented on code in PR #11294:
URL: https://github.com/apache/ignite/pull/11294#discussion_r1556587293


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/AbstractFileIO.java:
##########
@@ -57,14 +57,29 @@ private int fully(IOOperation operation, long position, int 
num, boolean write)
                     time = 0;
                 }
                 else if (n == 0 || i > 0) {
+                /* Condition for reaching the end of file while there's still 
space in buffer

Review Comment:
   Commentary removed, javadoc for the return value added. As for the buffer 
that I meant, the readFully() and writeFully() methods pass the number of 
remaining element in source/destination buffers to the fully() method (the 
'num' parameter in the fully() method):
   
![image](https://github.com/apache/ignite/assets/153691984/a2f56982-0f03-4eb5-b855-ced4f16bba4e)
   
![image](https://github.com/apache/ignite/assets/153691984/94fd171c-d49e-4bd6-966c-dfbb6dbdf9e9)
   
![image](https://github.com/apache/ignite/assets/153691984/b820da0e-4a9d-4d9e-99ce-2ccd0c3935e6)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to