timoninmaxim commented on code in PR #11294:
URL: https://github.com/apache/ignite/pull/11294#discussion_r1557086248
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/AbstractFileIO.java:
##########
@@ -62,9 +64,19 @@ else if (n == 0 || i > 0) {
if (time == 0)
time = System.nanoTime();
- else if ((System.nanoTime() - time) >=
U.millisToNanos(MAX_IO_TIMEOUT_MS))
- throw new IOException(write && (position + i) ==
size() ? "Failed to extend file." :
- "Probably disk is too busy, please check your
device.");
+ else if ((System.nanoTime() - time) >=
U.millisToNanos(MAX_IO_TIMEOUT_MS)) {
+ String errMsg = " operation unsuccessful, write
timeout exceeds the maximum IO timeout ("
+ + U.millisToNanos(MAX_IO_TIMEOUT_MS) + " ms); ";
+
+ if (write && (position + i) == size())
+ errMsg = "Write" + errMsg + "failed to extend
file.";
+ else if (write)
+ errMsg = "Write" + errMsg + "disk might be too
busy, please check your device.";
+ else
+ errMsg = "Read" + errMsg + "disk might be too
busy, please check your device.";
Review Comment:
There is still a code duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
