ygerzhedovich commented on code in PR #3583:
URL: https://github.com/apache/ignite-3/pull/3583#discussion_r1562380539
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/UpdatableTableImpl.java:
##########
@@ -349,4 +357,25 @@ private static RuntimeException
conflictKeysException(List<String> conflictKeys)
private interface PartitionExtractor {
int fromRow(BinaryRowEx row);
}
+
+ private <RowT> void validateNotNullConstraint(RowHandler<RowT> rowHandler,
List<RowT> rows) {
+ for (RowT row : rows) {
+ validateNotNullConstraint(rowHandler, row);
+ }
+ }
+
+ private <RowT> void validateNotNullConstraint(RowHandler<RowT> rowHandler,
RowT row) {
+ for (int i = 0; i < desc.columnsCount(); i++) {
Review Comment:
Also may be better to have new method for rowHandler to check value on null
- it can be more optimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
