ygerzhedovich commented on code in PR #3583: URL: https://github.com/apache/ignite-3/pull/3583#discussion_r1565809982
########## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItNotNullConstraintTest.java: ########## @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine; + +import static org.apache.ignite.internal.sql.engine.util.SqlTestUtils.assertThrowsSqlException; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.containsString; +import static org.junit.jupiter.api.Assertions.assertInstanceOf; +import static org.junit.jupiter.api.Assertions.assertThrows; + +import java.util.AbstractMap.SimpleEntry; +import java.util.Map; +import java.util.Map.Entry; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionException; +import java.util.concurrent.SubmissionPublisher; +import java.util.concurrent.TimeUnit; +import org.apache.ignite.internal.sql.BaseSqlIntegrationTest; +import org.apache.ignite.lang.ErrorGroups.Sql; +import org.apache.ignite.lang.MarshallerException; +import org.apache.ignite.table.DataStreamerItem; +import org.apache.ignite.table.KeyValueView; +import org.apache.ignite.table.RecordView; +import org.apache.ignite.table.Table; +import org.apache.ignite.table.Tuple; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.Disabled; +import org.junit.jupiter.api.Test; + +/** + * NOT NULL constraint tests. + */ +public class ItNotNullConstraintTest extends BaseSqlIntegrationTest { + + @AfterEach + public void clear() { + dropAllTables(); + } + + @Test + public void testSqlNotNullConstraints() { + sql("CREATE TABLE t1 (id INTEGER PRIMARY KEY, int_col INTEGER NOT NULL)"); + + // INSERT + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'ID' does not allow NULLs", + () -> sql("INSERT INTO t1 VALUES(NULL, 1)")); + + // KV case + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("INSERT INTO t1 VALUES(1, NULL)")); + + // General case + + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("INSERT INTO t1 VALUES(1, (SELECT NULL))")); + + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("INSERT INTO t1 SELECT 1, NULL")); + + // UPDATE + sql("INSERT INTO t1 VALUES(1, 42)"); + + assertThrowsSqlException( + Sql.STMT_VALIDATION_ERR, + "Cannot update field \"ID\". Primary key columns are not modifiable", + () -> sql("UPDATE t1 SET id = NULL WHERE val = 42")); + + // KV case + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("UPDATE t1 SET int_col = null WHERE id = 1")); + + // General case + + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("UPDATE t1 SET int_col = null")); + + // MERGE + sql("CREATE TABLE t2 (id INTEGER PRIMARY KEY, int_col INTEGER NOT NULL)"); + + sql("INSERT INTO t2 VALUES (1, 42)"); + + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("MERGE INTO t2 dst USING t1 src ON dst.id = src.id WHEN MATCHED THEN UPDATE SET int_col = NULL")); + + sql("INSERT INTO t1 VALUES (2, 71)"); + + assertThrowsSqlException( + Sql.CONSTRAINT_VIOLATION_ERR, + "Column 'INT_COL' does not allow NULLs", + () -> sql("MERGE INTO t2 dst USING t1 src ON dst.id = src.id " + + "WHEN NOT MATCHED THEN INSERT (id, int_col) VALUES (src.id, NULL)")); + + } + + @Test + @Disabled("https://issues.apache.org/jira/browse/IGNITE-22040";) + public void testKeyValueView() { + sql("CREATE TABLE kv (id INTEGER PRIMARY KEY, val INTEGER NOT NULL)"); + + Table table = CLUSTER.aliveNode().tables().table("KV"); + + { + KeyValueView<Integer, Integer> view = table.keyValueView(Integer.class, Integer.class); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + view.put(null, 1, null); + }); + assertThat(err.getMessage(), containsString("Column 'VAL' does not allow NULLs")); + } + + { + KeyValueView<Tuple, Tuple> view = table.keyValueView(); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + view.put(null, Tuple.create(Map.of("id", 1)), Tuple.create()); + }); + assertThat(err.getMessage(), containsString("Column 'VAL' does not allow NULLs")); + } + + { + KeyValueView<Integer, Val> view = table.keyValueView(Integer.class, Val.class); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + Val val = new Val(); + view.put(null, 1, val); + }); + assertThat(err.getMessage(), containsString("Column 'VAL' does not allow NULLs")); + } + } + + @Test + @Disabled("https://issues.apache.org/jira/browse/IGNITE-22040";) + public void testRecordView() { + sql("CREATE TABLE kv (id INTEGER PRIMARY KEY, val INTEGER NOT NULL)"); + + Table table = CLUSTER.aliveNode().tables().table("KV"); + + { + RecordView<Rec> view = table.recordView(Rec.class); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + Rec rec = new Rec(); + view.insert(null, rec); + }); + assertThat(err.getMessage(), containsString("Column 'ID' does not allow NULLs")); + } + + { + RecordView<Rec> view = table.recordView(Rec.class); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + Rec rec = new Rec(); + rec.id = 42; + view.insert(null, rec); + }); + assertThat(err.getMessage(), containsString("Column 'VAL' does not allow NULLs")); + } + + { + RecordView<Tuple> view = table.recordView(); + MarshallerException err = assertThrows(MarshallerException.class, () -> { + view.insert(null, Tuple.create(Map.of("id", 1))); + }); + assertThat(err.getMessage(), containsString("Column 'VAL' does not allow NULLs")); + } + } + + @Test + @Disabled("https://issues.apache.org/jira/browse/IGNITE-22040";) + public void testKeyValueViewDataStreamer() { + sql("CREATE TABLE kv (id INTEGER PRIMARY KEY, val INTEGER NOT NULL)"); + + Table table = CLUSTER.aliveNode().tables().table("KV"); + + { + KeyValueView<Tuple, Tuple> view = table.keyValueView(); + + checkDataStreamer(view, new SimpleEntry<>(Tuple.create(Map.of("id", 1)), Tuple.create()), "VAL"); + } + + + { + KeyValueView<Integer, Integer> view = table.keyValueView(Integer.class, Integer.class); + checkDataStreamer(view, new SimpleEntry<>(1, null), "VAL"); + } + + { + KeyValueView<Integer, Val> view = table.keyValueView(Integer.class, Val.class); + Val val = new Val(); + checkDataStreamer(view, new SimpleEntry<>(1, val), "VAL"); + } + } + + @Test + @Disabled("https://issues.apache.org/jira/browse/IGNITE-22040";) Review Comment: I'm not sure that is a good idea to disable these tests. We can check the current behavior and rework it when IGNITE-22040 is taken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
