vldpyatkov commented on code in PR #3422:
URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562411807
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1459,12 +1467,6 @@ private CompletableFuture<Void> destroyTableLocally(int
tableId) {
InternalTable internalTable = table.internalTable();
int partitions = internalTable.partitions();
- // TODO https://issues.apache.org/jira/browse/IGNITE-18991 Move
assigment manipulations to Distribution zones.
- Set<ByteArray> assignmentKeys = IntStream.range(0, partitions)
- .mapToObj(p -> stablePartAssignmentsKey(new
TablePartitionId(tableId, p)))
- .collect(toSet());
- metaStorageMgr.removeAll(assignmentKeys);
Review Comment:
It has to be done by @alievmirza.
Can you explain where we are removing stable assignment? I am sure it should
be done when a zone is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
