vldpyatkov commented on code in PR #3422:
URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1562422376
##########
modules/runner/src/main/java/org/apache/ignite/internal/app/IgniteImpl.java:
##########
@@ -596,10 +611,18 @@ public class IgniteImpl implements Ignite {
logicalTopologyService,
raftMgr,
topologyAwareRaftGroupServiceFactory,
- clockService
- );
+ clockService,
+ tablePartId -> {
+ CatalogTableDescriptor tbl =
catalogManager.table(tablePartId.tableId(),
catalogManager.latestCatalogVersion());
- ReplicationConfiguration replicationConfig =
clusterConfigRegistry.getConfiguration(ReplicationConfiguration.KEY);
+ int zoneId = tbl == null ? 2 : tbl.zoneId();
Review Comment:
It is a really complicated question for me.
Here, I try to return a default group id, because the default group always
exists and the table probably belongs to default. Finally, nobody promised that
the placement driver might not make a mistake.
But currently, we do not know an ID for the default replication group. I
think it has to be a constant, otherwise the consequences of this might be
freezing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]