Cyrill commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1576565805
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -191,16 +191,18 @@ public CompletableFuture<Void> start() {
updateLog.registerUpdateHandler(new OnUpdateHandlerImpl());
- updateLog.start();
+ updateLog.startAsync();
return nullCompletedFuture();
}
@Override
- public void stop() throws Exception {
+ public CompletableFuture<Void> stopAsync() {
busyLock.block();
versionTracker.close();
- updateLog.stop();
+ updateLog.stopAsync();
Review Comment:
fixed
##########
modules/catalog/src/main/java/org/apache/ignite/internal/catalog/CatalogManagerImpl.java:
##########
@@ -191,16 +191,18 @@ public CompletableFuture<Void> start() {
updateLog.registerUpdateHandler(new OnUpdateHandlerImpl());
- updateLog.start();
+ updateLog.startAsync();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
