sanpwc commented on code in PR #3629:
URL: https://github.com/apache/ignite-3/pull/3629#discussion_r1579468084
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerRecoveryTest.java:
##########
@@ -81,8 +81,8 @@ public class CatalogManagerRecoveryTest extends
BaseIgniteAbstractTest {
private TestUpdateHandlerInterceptor interceptor;
@AfterEach
- void tearDown() throws Exception {
- IgniteUtils.stopAll(catalogManager, metaStorageManager);
+ void tearDown() {
+ assertThat(IgniteUtils.stopAsync(catalogManager, metaStorageManager),
willCompleteSuccessfully());
Review Comment:
stopAsync according to how it's implemented now is not an equivalent of an
original stopAll that 've used closeAll that on its turn proceeds with
components stopping even in case of exception thrown from the synchronous part
of the stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
