AMashenkov commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579072271
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##########
@@ -1748,19 +1754,12 @@ public void
userFutureCompletesAfterClusterWideActivationHappens() throws Except
// TODO: remove after IGNITE-20378 is implemented.
@Test
public void
userFutureCompletesAfterClusterWideActivationWithAdditionalIdleSafeTimePeriodHappens()
throws Exception {
- long delayDuration = TimeUnit.DAYS.toMillis(365);
- long partitionIdleSafeTimePropagationPeriod =
TimeUnit.DAYS.toDays(365);
+ delayDuration.set(TimeUnit.DAYS.toMillis(365));
+ partitionIdleSafeTimePropagationPeriod.set(TimeUnit.DAYS.toDays(365));
- HybridTimestamp startTs = clock.now();
-
- CatalogManagerImpl manager = new CatalogManagerImpl(
- updateLog,
- clockService,
- delayDuration,
- partitionIdleSafeTimePropagationPeriod
- );
+ reset(clockWaiter);
- manager.start();
Review Comment:
try-finally is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
