korlov42 commented on code in PR #3653:
URL: https://github.com/apache/ignite-3/pull/3653#discussion_r1579110626
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##########
@@ -1719,14 +1728,11 @@ public void testColumnEvents() {
@Test
public void userFutureCompletesAfterClusterWideActivationHappens() throws
Exception {
- long delayDuration = TimeUnit.DAYS.toMillis(365);
+ delayDuration.set(TimeUnit.DAYS.toMillis(365));
+ reset(clockWaiter);
HybridTimestamp startTs = clock.now();
- CatalogManagerImpl manager = new CatalogManagerImpl(updateLog,
clockService, delayDuration, 0);
-
- manager.start();
Review Comment:
good catch! fixed
##########
modules/catalog/src/test/java/org/apache/ignite/internal/catalog/CatalogManagerSelfTest.java:
##########
@@ -1167,14 +1180,9 @@ public void catalogActivationTime() throws Exception {
@Test
public void createTableIfNotExistWaitsActivationEvenIfTableExists() throws
Exception {
- long delayDuration = TimeUnit.DAYS.toMillis(365);
-
- int partitionIdleSafeTimePropagationPeriod = 0;
-
- CatalogManagerImpl manager = new CatalogManagerImpl(updateLog,
clockService, delayDuration,
- partitionIdleSafeTimePropagationPeriod);
-
- manager.start();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
