zstan commented on code in PR #3734: URL: https://github.com/apache/ignite-3/pull/3734#discussion_r1598286615
########## modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test: ########## @@ -0,0 +1,209 @@ +# name: sql/identifiers/test_long_identifiers.test +# description: SQL feature F391 (Long identifiers) +# group: [identifiers] + +# TODO: IGNITE-19703 Add cases for long identifiers for schema names. + +statement ok +PRAGMA enable_verification + +# Create table with short identifiers for test simplicity purpose +statement ok +CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id)) + +# Create table with long identifiers +statement ok +CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters)); + +statement error +CREATE TABLE tableName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters (key INTEGER, val INTEGER, PRIMARY KEY (key)); + + +# Rename table with long identifiers +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement error +# ALTER TABLE t RENAME TO tableName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters; +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement ok +# ALTER TABLE t RENAME TO tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters; +# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed. +# statement ok +# ALTER TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters RENAME TO tableName; + + +# Alter table add/drop column with long identifier +statement ok +ALTER TABLE t ADD COLUMN (columnName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER); + +statement error +ALTER TABLE t ADD COLUMN (columnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters INTEGER); + +statement ok +ALTER TABLE t DROP COLUMN (columnName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters); + + +# Alter table rename column with long identifier +# TODO: IGNITE-19485, IGNITE-20315 - Uncomment this after column rename support gets aded. Review Comment: common pattern is to use : skipif, i.e. ``` skipif ignite3 # Ignored: https://issues.apache.org/jira/browse/IGNITE-xxxxx query T ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
