lowka commented on code in PR #3734: URL: https://github.com/apache/ignite-3/pull/3734#discussion_r1598489377
########## modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test: ########## @@ -0,0 +1,209 @@ +# name: sql/identifiers/test_long_identifiers.test +# description: SQL feature F391 (Long identifiers) +# group: [identifiers] + +# TODO: IGNITE-19703 Add cases for long identifiers for schema names. + +statement ok +PRAGMA enable_verification + +# Create table with short identifiers for test simplicity purpose +statement ok +CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id)) + +# Create table with long identifiers +statement ok +CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters)); + +statement error Review Comment: Could you please include an error message check here ? I can be done by using the following syntax > statement error: Blah blah blah > SELECT WRONG ########## modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test: ########## @@ -0,0 +1,209 @@ +# name: sql/identifiers/test_long_identifiers.test +# description: SQL feature F391 (Long identifiers) +# group: [identifiers] + +# TODO: IGNITE-19703 Add cases for long identifiers for schema names. + +statement ok +PRAGMA enable_verification + +# Create table with short identifiers for test simplicity purpose +statement ok +CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id)) + +# Create table with long identifiers +statement ok +CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters)); + +statement error Review Comment: Could you please include an error message check here ? It can be done by using the following syntax > statement error: Blah blah blah > SELECT WRONG -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
