Phillippko commented on code in PR #3933:
URL: https://github.com/apache/ignite-3/pull/3933#discussion_r1642742571
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryMvTableStorageTest.java:
##########
@@ -57,10 +60,18 @@ public class VolatilePageMemoryMvTableStorageTest extends
AbstractMvTableStorage
@BeforeEach
void setUp(
+ TestInfo testInfo,
@InjectConfiguration VolatilePageMemoryStorageEngineConfiguration
engineConfig,
@InjectConfiguration("mock.profiles.default = {engine =
\"aimem\"}")
StorageConfiguration storageConfiguration
) {
+ if (testInfo.getTags().contains(LOW_MEMORY_TAG)) {
Review Comment:
By default we allocate 3 gigabytes of memory, so we need a lot of iterations
to overflow memory if we have leakages. I.e. without my fix volatile memory
fails only after 51 thousand iterations with default memory settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
