Phillippko commented on code in PR #3933:
URL: https://github.com/apache/ignite-3/pull/3933#discussion_r1642789447
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryMvTableStorageTest.java:
##########
@@ -57,10 +60,18 @@ public class VolatilePageMemoryMvTableStorageTest extends
AbstractMvTableStorage
@BeforeEach
void setUp(
+ TestInfo testInfo,
@InjectConfiguration VolatilePageMemoryStorageEngineConfiguration
engineConfig,
@InjectConfiguration("mock.profiles.default = {engine =
\"aimem\"}")
StorageConfiguration storageConfiguration
) {
+ if (testInfo.getTags().contains(LOW_MEMORY_TAG)) {
Review Comment:
Removed. Moved test to volatile test class (at first didn't realize that
it's not valid for persistent), and added more iterations - it still takes only
4 seconds, but without my fix overflows even with default memory settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
