JAkutenshi commented on code in PR #3973:
URL: https://github.com/apache/ignite-3/pull/3973#discussion_r1686482049
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -190,6 +205,9 @@ public PartitionReplicaLifecycleManager(
this.lowWatermark = lowWatermark;
this.ioExecutor = ioExecutor;
this.rebalanceScheduler = rebalanceScheduler;
+ this.clockService = clockService;
+ // should it be ExecutorInclinedPlacementDriver as in TableManager?
Review Comment:
Couldn't pass `ExecutorInclinedPlacementDriver` there because it came from
`:ignite-table`, but there a circular dependency arises:
```
:ignite-partition-replicator:compileJava
\--- :ignite-table:compileJava
\--- :ignite-partition-replicator:compileJava (*)
```
Is it crucial?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
