JAkutenshi commented on code in PR #3973:
URL: https://github.com/apache/ignite-3/pull/3973#discussion_r1686488411
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -967,19 +1008,63 @@ private CompletableFuture<Void> changePeersOnRebalance(
PeersAndLearners newConfiguration =
fromAssignments(pendingAssignments);
- CompletableFuture<Void> voidCompletableFuture
= partGrpSvc.changePeersAsync(newConfiguration,
+ CompletableFuture<Void> voidCompletableFuture
= raftClient.changePeersAsync(newConfiguration,
leaderWithTerm.term()).exceptionally(e
-> {
return null;
});
return voidCompletableFuture;
});
- });
+ }));
}
private boolean isLocalPeer(Peer peer) {
return peer.consistentId().equals(localNode().name());
}
+ private boolean isLocalNodeInAssignments(Collection<Assignment>
assignments) {
+ return assignments.stream().anyMatch(isLocalNodeAssignment);
+ }
+
+ private CompletableFuture<Boolean>
isLocalNodeLeaseholder(ReplicationGroupId replicationGroupId) {
Review Comment:
Java doc is added, the method is fixed due to the lifecycle manager's
version some how became is out of date a little.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
