ygerzhedovich commented on code in PR #4141:
URL: https://github.com/apache/ignite-3/pull/4141#discussion_r1696834755
##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/catalog/CatalogToSchemaDescriptorConverterTest.java:
##########
@@ -57,8 +57,7 @@ public class CatalogToSchemaDescriptorConverterTest extends
AbstractSchemaConver
private static final int TEST_SCALE = 5;
private static Stream<NativeTypeSpec> nativeTypeSpecs() {
- return Stream.of(NativeTypeSpec.values())
- .filter(t -> t != NativeTypeSpec.NUMBER && t !=
NativeTypeSpec.BITMASK);
+ return Stream.of(NativeTypeSpec.values());
Review Comment:
it will be better to rewrite it to EnumSource instead of the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
