korlov42 commented on code in PR #4141:
URL: https://github.com/apache/ignite-3/pull/4141#discussion_r1697995758
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -106,12 +100,12 @@ public enum ColumnType {
private final int id;
- private static final ColumnType[] VALS = new ColumnType[values().length];
+ private static final Int2ObjectMap<ColumnType> VALS = new
Int2ObjectOpenHashMap<>();
Review Comment:
I'm wondering why map is better than array? we have only one gap, and the
only method using this collections is ready to `null` being returned. Does it
make sense to just mark values in the array as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
