sanpwc commented on code in PR #4162:
URL: https://github.com/apache/ignite-3/pull/4162#discussion_r1698323305
##########
modules/network/src/main/java/org/apache/ignite/internal/network/DefaultMessagingService.java:
##########
@@ -418,17 +418,29 @@ private void handleMessageFromNetwork(InNetworkObject
inNetworkObject) {
logAndRethrowIfError(inNetworkObject, e);
} finally {
long tookMillis =
TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startedNanos);
+
if (tookMillis > 100) {
- LOG.warn("Processing of {} from {} took {} ms",
inNetworkObject.message(), inNetworkObject.sender(), tookMillis);
+ LOG.warn(
+ "Processing of {} from {} took {} ms",
+ LOG.isDebugEnabled() ? inNetworkObject.message() :
inNetworkObject.message().toStringForLightLogging(),
Review Comment:
Should we also add `&& includeSensitive()` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]